cipher: add scytale cipher #12395
cipher: add scytale cipher #12395
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,73 @@ | |||
| import math | |||
|
|
|||
| def encrypt_columnar_cipher(message: str, key: str) -> str: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/columnar_transposition_cipher.py, please provide doctest for the function encrypt_columnar_cipher
| grid[i % num_cols] += char | ||
|
|
||
| # Sort columns based on the key order | ||
| sorted_key_indices = sorted(range(len(key)), key=lambda k: key[k]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: k
| return ciphertext | ||
|
|
||
|
|
||
| def decrypt_columnar_cipher(ciphertext: str, key: str) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/columnar_transposition_cipher.py, please provide doctest for the function decrypt_columnar_cipher
| num_shaded_boxes = (num_cols * num_rows) - len(ciphertext) | ||
|
|
||
| # Sort columns based on the key order | ||
| sorted_key_indices = sorted(range(len(key)), key=lambda k: key[k]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: k
| @@ -0,0 +1,59 @@ | |||
| def encrypt_scytale_cipher(message: str, key: int) -> str: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/scytale_cipher.py, please provide doctest for the function encrypt_scytale_cipher
| return "".join(ciphertext) | ||
|
|
||
|
|
||
| def decrypt_scytale_cipher(ciphertext: str, key: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/scytale_cipher.py, please provide doctest for the function decrypt_scytale_cipher
for more information, see https://pre-commit.ci
Describe your change:
Checklist: